Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Make darktable 4.6 supporting GIMP #15973

Conversation

jenshannoschwalm
Copy link
Collaborator

@jenshannoschwalm jenshannoschwalm commented Dec 27, 2023

The GIMP darktable loader does some regex searching after calling darktable --version, this expects

  1. "this is darktable ..." as the initial string, in master we have "darktable ..."
  2. "Lua support enabled" somewhere following

We might want to make the GIMP team aware of the textual changes but until that has been fixed upstream we make sure we use the old style if we use the --version switch. EDIT: discussion with gimp team started

Fixes #15968

@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes labels Dec 27, 2023
@jenshannoschwalm jenshannoschwalm added this to the 4.6.1 milestone Dec 27, 2023
@TurboGit
Copy link
Member

Even the last line Lua is needed:

this is darktable 4.7.0+77~gc634e7a95f-dirty
Copyright (C) 2012-2023 Johannes Hanika and other contributors.

Compile options:
  Bit depth              -> 64 bit
  Debug                  -> DISABLED
  SSE2 optimizations     -> ENABLED
  OpenMP                 -> ENABLED
  OpenCL                 -> ENABLED
  Lua                    -> ENABLED  - API version 9.2.0
  Colord                 -> ENABLED
  gPhoto2                -> ENABLED
  GMIC                   -> ENABLED  - Compressed LUTs are supported
  GraphicsMagick         -> ENABLED
  ImageMagick            -> DISABLED
  libavif                -> ENABLED
  libheif                -> ENABLED
  libjxl                 -> ENABLED
  OpenJPEG               -> ENABLED
  OpenEXR                -> ENABLED
  WebP                   -> ENABLED

See https://www.darktable.org/resources/ for detailed documentation.
See https://github.com/darktable-org/darktable/issues/new/choose to report bugs.
Lua support enabled

I'm ok to merge into 4.6.1 (only) to fix GIMP support but not in master where I do prefer waiting for GIMP loaded to be fixed.

@jenshannoschwalm
Copy link
Collaborator Author

Fine with me. I would suggest to offer a darktable --gimp-support switch simply returning "OK" ? Would check with the gimp team?

@TurboGit
Copy link
Member

Fine with me. I would suggest to offer a darktable --gimp-support switch simply returning "OK" ? Would check with the gimp team?

Would certainly be better to have such option as we would avoid in the future to break things again.

@jenshannoschwalm
Copy link
Collaborator Author

For me it's ready for 4.6 or would you prefer a "decent" 4.6 PR?

BTW i opened a ticket at GIMP

The GIMP darktable loader does some regex searching after calling `darktable --version`,
this expects
1. "this is darktable ..." as the initial string, in master we have "darktable ..."
2. "Lua support enabled" somewhere following

We might want to make the GIMP team aware of the textual changes but until that has been
fixed upstream we make sure we use the old style if we use the --version switch.
@TurboGit
Copy link
Member

TurboGit commented Jan 3, 2024

My idea was to wait and add here the --gimp-support option otherwise when GIMP implements the new way darktable 4.6.x won't work anymore. So maybe better wait for GIMP devs feedback. If no decision taken when we do the 4.6.1 release we will merge this.

@jenshannoschwalm
Copy link
Collaborator Author

Agreed.

@Jehan
Copy link

Jehan commented Jan 11, 2024

A small note to confirm that we'd be very happy for a dedicated flag. See the discussion here: https://gitlab.gnome.org/GNOME/gimp/-/issues/10572

In particular, we are discussing with @jenshannoschwalm a possible evolution of having this flag producing structured syntax to allow for easier evolution. And this even evolved further with some of the contents being the CLI options to use, so that it's controlled on darktable side rather than hardcoded in the GIMP plug-in.

This way, it would make you much more free to have things evolve and GIMP would not break when you change something; nor would our plug-in need to be updated when you add new interesting features we should use.

@gi-man
Copy link
Contributor

gi-man commented Jan 13, 2024

Reading thru the GIMP thread, it is starting to sound like the flag should be a new feature for 4.8 vs a 4.6.1 fix. They might benefit of using darktable-cli

@jenshannoschwalm
Copy link
Collaborator Author

How to proceed on this? Let's see how fast the gimp people can integrate the new darktable gimp API?

@TurboGit
Copy link
Member

TurboGit commented Feb 3, 2024

Given that 4.6.1 is targeted a bit after Feb 15th I think this should go into 4.6.x branch.

@AxelG-DE
Copy link

AxelG-DE commented Feb 12, 2024

Maybe a minor compared to the things you guys are dealing here, but just let you know:

  • dt.bldr.sh https://github.com/jade-nl/dt.bldr is relying on this version string to
  • and stumbled when "This is" disappeared.
  • If I am not mistaken, the current implementation might be more robust but I am not 100% sure

@Jehan
Copy link

Jehan commented Feb 12, 2024

Sorry for not reviewing this sooner on our side. We are currently releasing a dev version of GIMP with a lot of color-management related change which is one of the test focus right now. I'll be able to review whatever needs to be reviewed for the GIMP-darktable integration when it's all settled down (in a few days).

Or else, I just trust you to do the right thing (it's good too 😉).

@TurboGit
Copy link
Member

@Jehan : I'm cutting the sources for the release in 5 days, this PR will go into 4.6.1 at this stage. So GIMP stable release will be able to use darktable as it was before.

We have now merged in master the --gimp option with the discussed support and this will be available in darktable 4.8 on June 21st.

@TurboGit
Copy link
Member

Manually merged in 4.6.x branch.

@TurboGit TurboGit closed this Feb 15, 2024
@TurboGit TurboGit self-requested a review February 15, 2024 18:44
@jenshannoschwalm jenshannoschwalm deleted the fix_gimp_support branch February 15, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gimp cannot find darktable plugin for version 4.6.0
5 participants