-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Make darktable 4.6 supporting GIMP #15973
Bugfix: Make darktable 4.6 supporting GIMP #15973
Conversation
Even the last line Lua is needed:
I'm ok to merge into 4.6.1 (only) to fix GIMP support but not in master where I do prefer waiting for GIMP loaded to be fixed. |
Fine with me. I would suggest to offer a |
Would certainly be better to have such option as we would avoid in the future to break things again. |
For me it's ready for 4.6 or would you prefer a "decent" 4.6 PR? BTW i opened a ticket at GIMP |
The GIMP darktable loader does some regex searching after calling `darktable --version`, this expects 1. "this is darktable ..." as the initial string, in master we have "darktable ..." 2. "Lua support enabled" somewhere following We might want to make the GIMP team aware of the textual changes but until that has been fixed upstream we make sure we use the old style if we use the --version switch.
e85a0dd
to
110a661
Compare
My idea was to wait and add here the |
Agreed. |
A small note to confirm that we'd be very happy for a dedicated flag. See the discussion here: https://gitlab.gnome.org/GNOME/gimp/-/issues/10572 In particular, we are discussing with @jenshannoschwalm a possible evolution of having this flag producing structured syntax to allow for easier evolution. And this even evolved further with some of the contents being the CLI options to use, so that it's controlled on darktable side rather than hardcoded in the GIMP plug-in. This way, it would make you much more free to have things evolve and GIMP would not break when you change something; nor would our plug-in need to be updated when you add new interesting features we should use. |
Reading thru the GIMP thread, it is starting to sound like the flag should be a new feature for 4.8 vs a 4.6.1 fix. They might benefit of using darktable-cli |
How to proceed on this? Let's see how fast the gimp people can integrate the new darktable gimp API? |
Given that 4.6.1 is targeted a bit after Feb 15th I think this should go into 4.6.x branch. |
Maybe a minor compared to the things you guys are dealing here, but just let you know:
|
Sorry for not reviewing this sooner on our side. We are currently releasing a dev version of GIMP with a lot of color-management related change which is one of the test focus right now. I'll be able to review whatever needs to be reviewed for the GIMP-darktable integration when it's all settled down (in a few days). Or else, I just trust you to do the right thing (it's good too 😉). |
@Jehan : I'm cutting the sources for the release in 5 days, this PR will go into 4.6.1 at this stage. So GIMP stable release will be able to use darktable as it was before. We have now merged in master the |
Manually merged in 4.6.x branch. |
The GIMP darktable loader does some regex searching after calling
darktable --version
, this expectsWe might want to make the GIMP team aware of the textual changes but until that has been fixed upstream we make sure we use the old style if we use the --version switch. EDIT: discussion with gimp team started
Fixes #15968